Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIxed:314] add rule selector-no-union-class-name #338

Merged
merged 5 commits into from Jun 29, 2019

Conversation

pipopotamasu
Copy link
Contributor

@pipopotamasu pipopotamasu commented Jun 27, 2019

Added new rule to fix #314.

This rule disallow to union class name like this.

@coveralls
Copy link

coveralls commented Jun 27, 2019

Coverage Status

Coverage increased (+0.03%) to 92.22% when pulling a83dc5f on pipopotamasu:issue#314 into f580170 on kristerkari:master.

@pipopotamasu pipopotamasu changed the title [WIP] add selector-no-union-class-name [WIP] add rule selector-no-union-class-name Jun 27, 2019
@pipopotamasu pipopotamasu changed the title [WIP] add rule selector-no-union-class-name [WIP] [FIxed:314] add rule selector-no-union-class-name Jun 27, 2019
@pipopotamasu pipopotamasu changed the title [WIP] [FIxed:314] add rule selector-no-union-class-name [FIxed:314] add rule selector-no-union-class-name Jun 27, 2019
@kristerkari
Copy link
Collaborator

Thanks! I'll try to review this asap.

src/rules/selector-no-union-class-name/index.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@kristerkari kristerkari merged commit c2875f3 into stylelint-scss:master Jun 29, 2019
@kristerkari
Copy link
Collaborator

Great! Thanks!

@kristerkari
Copy link
Collaborator

Thanks again, released in 3.9.0:
https://github.com/kristerkari/stylelint-scss/releases/tag/3.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

New Rule Idea: forbid &-className syntax
3 participants